Allow `selenium-webdriver` 4.0.0

yahonda commented 2 years ago

This pull request resolves the Rails issue https://github.com/rails/rails/issues/43455

Since selenium-webdriver 4.0.0 has been released, webdriver 4.6 is not allowed likely due to version limitation in webdrivers.gemspec.

bundle install failure at Rails issue 43455


$ bundle install
Warning: the running version of Bundler (2.2.22) is older than the version that created the lockfile (2.2.29). We suggest you to upgrade to the version that created the lockfile by running `gem install bundler:2.2.29`.
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies.........
Bundler could not find compatible versions for gem "selenium-webdriver":
In Gemfile:
selenium-webdriver (>= 4.0.0.alpha7)

webdrivers was resolved to 4.6.0, which depends on
  selenium-webdriver (>= 3.0, < 4.0)

Could not find gem 'selenium-webdriver (>= 3.0, < 4.0)', which is required by gem 'webdrivers', in source at /home/yahonda/src/github.com/SeleniumHQ/selenium.

Bundler could not find compatible versions for gem "webdrivers": In snapshot (Gemfile.lock): webdrivers (= 4.6.0)

In Gemfile: webdrivers

Running bundle update will rebuild your snapshot from scratch, using only the gems in your Gemfile, which may resolve the conflict. $



Refer
https://rubygems.org/gems/selenium-webdriver/versions/4.0.0

yahonda commented 2 years ago

Here is the minimum case to reproduce.

Gemfile
```
source "https://rubygems.org"
```

gem "webdrivers", "=4.6.1" gem "selenium-webdriver", "=4.0.0"


```ruby
$ ruby -v
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux]
$ bundle
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...
Bundler could not find compatible versions for gem "selenium-webdriver":
  In Gemfile:
    selenium-webdriver (= 4.0.0)

    webdrivers (= 4.6.1) was resolved to 4.6.1, which depends on
      selenium-webdriver (>= 3.0, < 4.0)
$

titusfortner commented 2 years ago

Yes, thanks for the contribution, few other problems that needed fixing. I'll get a release out shortly.

titusfortner / webdrivers

Allow `selenium-webdriver` 4.0.0 #218