search

titusfortner / webdrivers

Keep your Selenium WebDrivers updated automatically
MIT License
592 stars 113 forks source link

Set `WEBDRIVERS=1` env var while running drivers #227

Closed entretechno-jeremiah closed 2 years ago

entretechno-jeremiah commented 2 years ago

See https://github.com/titusfortner/webdrivers/issues/217#issuecomment-1019405659

@kapoorlakshya I've tested this on my machine (Ubuntu 21.10), and I've confirmed that it does make the env var available to my script. If you would be able to test this on Windows (mainly to make sure that it didn't break anything, not so much that the env var is present), that would be amazing. Thank you!

The reason I added intermediate scripts in bin/drivers/ is so that the env var is only set while that driver is actually running. I wanted to make sure that if a user launches a driver via this library and then launches a driver not via this library in the same script, it would have the env var set for the former but not the latter.

I totally understand if this is not an ideal change to this library. If not, my existing solution should work fine without the env var.

titusfortner commented 2 years ago

Yeah, this seems like an unnecessary complexity for a non-standard use case. You should be able to implement this in an alternate fashion locally if you need it.

Thanks!