search

titusfortner / webdrivers

Keep your Selenium WebDrivers updated automatically
MIT License
592 stars 113 forks source link

msedgedriver wrong version for OS being fetched #229

Closed dillonbarker-te closed 2 years ago

dillonbarker-te commented 2 years ago

Summary

Debug Info

Please provide the following information for bug reports:

Expected Behavior

It should try to download the correct version of the msedgedriver for my os and browser.

Actual Behavior

Net::HTTPServerException: 404 "Not Found" with https://msedgedriver.azureedge.net//98.0.1108.50/edgedriver_mac64.zip

jacob-ewald commented 2 years ago

Getting the same error for win32. The XML coming from https://msedgedriver.azureedge.net/ does not list 98.0.1108.51 (or .50) as a version, despite that being the version listed in the LATEST_STABLE file.

kapoorlakshya commented 2 years ago

@dillonbarker-te @jacob-ewald Is this still happening? I see that LATEST_STABLE is now pointing to 98.0.1108.56 which does exist.

kapoorlakshya commented 2 years ago

Either way, this is something that only Microsoft can solve because they control the downloads. The only thing webdrivers can do in this situation is allow you to pin to an available download version and ignore whatever LATEST_STABLE has. Once MS fixes the downloads, you can unpin and start using the latest.

dillonbarker-te commented 2 years ago

I got around it by retrying as it seemed it would attempt the correct version after trying twice. But i will check later for you whether it is happening without the retry. Thanks for the update.

Dillon Barker

On 23 Feb 2022, at 06:33, Lakshya Kapoor @.***> wrote:

 Either way, this is something that only Microsoft can solve because they control the downloads. The only thing webdrivers can do in this situation is allow you to pin to an available download version and ignore whatever LATEST_STABLE has. Once MS fixes the downloads, you can unpin and start using the latest.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

jacob-ewald commented 2 years ago

The releases and the XML that points at them seem to be in harmony again. Instead of pinning to a version, we introduced an environment variable that is set on our build server that ignores updates for a set period of time. Once that time elapses it will try to go through the standard update logic like normal. Seemed easier to maintain when these hiccups occur since I don't have to remember to unpin anything after the issue clears up.

kapoorlakshya commented 2 years ago

@jacob-ewald Sounds like your env var approach is similar to the cache time feature in webdrivers.

Closing this as everything seems to be working now.