titusfortner / webdrivers

Keep your Selenium WebDrivers updated automatically
MIT License
592 stars 113 forks source link

Download correct geckodriver version on MacOS M1 #231

Closed stephannv closed 2 years ago

stephannv commented 2 years ago

There are two MacOS geckodriver versions. If the wrong one is downloaded, the user receives "Bad CPU type in executable". More info here: https://github.com/mozilla/geckodriver/issues/1984. This commit is checking if system architecture is Apple M1 to provide the correct plataform_ext.

I didn't find any tests to check platform_ext behavior, so I don't know if makes sense test these strings.