Download correct geckdriver file on Apple Silicon

titusfortner / webdrivers

Keep your Selenium WebDrivers updated automatically

MIT License

592 stars 113 forks source link

Download correct geckdriver file on Apple Silicon #234

Closed stephannv closed 2 years ago

stephannv commented 2 years ago

Geckodriver splits its Mac OS files into 2 versions (macos.tar.gz and macos-aarch64.tar.gz), and webdrivers doesn't work properly if macos.tar.gz is used on Apple Sillicon platform. Geckodriver releases: https://github.com/mozilla/geckodriver/releases

kapoorlakshya commented 2 years ago

@stephannv Thanks for your contribution! Can you please add a test for this and rebase on main? I just fixed two broken tests and CI checks should be green now.

stephannv commented 2 years ago

Done @kapoorlakshya.

stephannv commented 2 years ago

Specs fixed.