Closed ansonhoyt closed 1 year ago
Thanks to your helpful Version Pinning docs ❤️ , my system tests are running great on the previous version:
# test/application_system_test_case.rb
require 'test_helper'
class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
Webdrivers::Chromedriver.required_version = '106.0.5249.21' # <= this version works
driven_by :selenium, using: :headless_chrome, screen_size: [1400, 1400]
end
Same issue here. https://chromedriver.storage.googleapis.com/index.html?path=106.0.5249.21/ works https://chromedriver.storage.googleapis.com/index.html?path=106.0.5249.61/ doesn't work
Oh Google...
Updating Chromedriver#driver_filename
to return a version appropriate filename should work:
Could either of you submit a PR? If not then I can try to take a look this week.
@kapoorlakshya I have submitted a PR for this issue
v5.2.0 has been released. Thanks again, @jmccure!
No worries, I have added some tests in this PR https://github.com/titusfortner/webdrivers/pull/240
Summary
It looks like Webdrivers'
download_file
gets a 404 because Google changed chromedriver's filename scheme with 106.0.5249.61.Debug Info
Expected Behavior
download_file
should download:https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac_arm64.zip
Actual Behavior
download_file
tried to download:https://chromedriver.storage.googleapis.com/106.0.5249.61/chromedriver_mac64_m1.zip
Looking through https://chromedriver.storage.googleapis.com/, the naming seems to change with chromedriver 106.0.5249.61.
It looks like driver_filename always returns "mac64_m1" but should start returning "mac_arm64" for new chromedriver releases.