search

titusfortner / webdrivers

Keep your Selenium WebDrivers updated automatically
MIT License
592 stars 113 forks source link

Fixes downloading on m1 macs from version 106.0.5249.61 onwards #241

Closed frenesim closed 1 year ago

frenesim commented 1 year ago

Fix a similar Issue to #237

The download is failing again for the newer chrome version. From version 106.0.5249.61 onwards seems the filename is 'chromedriver_mac_arm64.zip'.

https://chromedriver.storage.googleapis.com/

Let me know if we should open an issue to this one.

I found testing this change a bit hard, so I went on testing a private method 💀 . I tested the method I perceive as the best candidate to be the public API of a new class.

jmccure commented 1 year ago

@frenesim I don't think this really changes anything. The only change is the method name and changing the strings to double quotes. What error are you fixing? The two latest chromedriver versions have the same filename suffix.

106.0.5249.61/chromedriver_mac_arm64.zip 107.0.5304.18/chromedriver_mac_arm64.zip

Are you using the latest version of this gem?

Also I have tests that don't test the private methods in https://github.com/titusfortner/webdrivers/pull/240

frenesim commented 1 year ago

You are right. I thought I had the latest version, but no. Funny, we end up with almost the same code. :)