Closed sadahiro-ono closed 1 year ago
Thanks for the PR. It looks like it isn't backwards compatible. Can you look at why the tests are failing?
@titusfortner Local tests passed, but I made some fixes to lower the impact, could you please run a CI?
@titusfortner The main branch is also not passing the tests. I sorry, Could you please confirm this for me? https://github.com/titusfortner/webdrivers/actions/runs/5683791993/job/15405104246
expected StandardError with message matching /Net::HTTPServerException: 404 "Not Found"/, got #<Webdrivers::NetworkError: Net::HTTPClientException: 404 "Not Found" with https://github.com/mozilla/geckodriver/releases/download/v0.2.0/geckodriver-v0.2.0-linux64.tar.gz>
Just need to change from StandardError
to Webdrivers::NetworkError
Webdrivers::NetworkError: Net::HTTPClientException: 404 "Not Found" with https://msedgedriver.azureedge.net/114.0.1823.90/edgedriver_mac64.zip
https://msedgedriver.azureedge.net/ does not have this build 114.0.1823.90/edgedriver_mac64.zip
StandardError is the superclass, it is the value of the String it failed on. Not sure if it is happenstance or common that MS doesn't do releases for all platforms for all patch versions, but not good either way.
Merged here — https://github.com/titusfortner/webdrivers/commit/97fb1e2b842c427a885553ac695ecdbf303344ba
Thank you!
similar Issue: https://github.com/titusfortner/webdrivers/issues/247
f the version is 115 or higher, the API can be used, so if the version is 115 or higher, the stable version is obtained and downloaded from the API.
refarence