titusfortner / webdrivers

Keep your Selenium WebDrivers updated automatically
MIT License
592 stars 113 forks source link

Fixed Webdrivers::VersionError with chrome version greater than 115 #249

Closed sadahiro-ono closed 1 year ago

sadahiro-ono commented 1 year ago

similar Issue: https://github.com/titusfortner/webdrivers/issues/247

f the version is 115 or higher, the API can be used, so if the version is 115 or higher, the stable version is obtained and downloaded from the API.

refarence

titusfortner commented 1 year ago

Thanks for the PR. It looks like it isn't backwards compatible. Can you look at why the tests are failing?

sadahiro-ono commented 1 year ago

@titusfortner Local tests passed, but I made some fixes to lower the impact, could you please run a CI?

sadahiro-ono commented 1 year ago

@titusfortner The main branch is also not passing the tests. I sorry, Could you please confirm this for me? https://github.com/titusfortner/webdrivers/actions/runs/5683791993/job/15405104246

alexshenia commented 1 year ago

expected StandardError with message matching /Net::HTTPServerException: 404 "Not Found"/, got #<Webdrivers::NetworkError: Net::HTTPClientException: 404 "Not Found" with https://github.com/mozilla/geckodriver/releases/download/v0.2.0/geckodriver-v0.2.0-linux64.tar.gz>

Just need to change from StandardError to Webdrivers::NetworkError

alexshenia commented 1 year ago

Webdrivers::NetworkError: Net::HTTPClientException: 404 "Not Found" with https://msedgedriver.azureedge.net/114.0.1823.90/edgedriver_mac64.zip https://msedgedriver.azureedge.net/ does not have this build 114.0.1823.90/edgedriver_mac64.zip

titusfortner commented 1 year ago

StandardError is the superclass, it is the value of the String it failed on. Not sure if it is happenstance or common that MS doesn't do releases for all platforms for all patch versions, but not good either way.

titusfortner commented 1 year ago

Merged here — https://github.com/titusfortner/webdrivers/commit/97fb1e2b842c427a885553ac695ecdbf303344ba

Thank you!