search

titusjan / argos

Argos: a data viewer that can read HDF5, NetCDF4, and other file formats.
GNU General Public License v3.0
176 stars 26 forks source link

configure wheels, travis, tox and lint. #2

Closed graingert closed 7 years ago

titusjan commented 7 years ago

Hi Graingert.

I've spend some time this weekend looking at wheels and tox. I might switch to wheels in the future but for now I stick to setup.py as it works for me don't want to support both (as you can see I'm a bit conservative in these things).

I don't understand how tox could work with PyQt and Python 2.7 and 3.4, as it only possible to install PyQt with pip since Python 3.5. Does the .tox file you provide work for you? I get errors because it can't install PyQt.

Tox also doesn't match with Anaconda, which I'm beginning to like more and more.

I got another question. I see that you removed the invocation of main from all my test modules.

-if __name__ == '__main__':
-    configBasicLogging(level='DEBUG')
-    unittest.main()

You do you propose to execute the tests now?

graingert commented 7 years ago

pytest will automatically discover the tests.

On 15 Jan 2017 22:27, "Pepijn Kenter" notifications@github.com wrote:

Hi Graingert.

I've spend some time this weekend looking at wheels and tox. I might switch to wheels in the future but for now I stick to setup.py as it works for me don't want to support both (as you can see I'm a bit conservative in these things).

I don't understand how tox could work with PyQt and Python 2.7 and 3.4, as it only possible to install PyQt with pip since Python 3.5. Does the .tox file you provide work for you? I get errors because it can't install PyQt.

Tox also doesn't match with Anaconda, which I'm beginning to like more and more.

I got another question. I see that you removed the invocation of main from all my test modules.

-if name == 'main':

  • configBasicLogging(level='DEBUG')
  • unittest.main()

You do you propose to execute the tests now?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/titusjan/argos/pull/2#issuecomment-272741904, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZQTAa2xKFhEwq320ZN4Kv3FBL3NPtwks5rSp1WgaJpZM4LhpO3 .

titusjan commented 7 years ago

Thanks again for contributing. I did not use all your edits but took what was useful for me. I left out the Travis, Tox and PyTest parts; I will not use these tools for now (maybe later).