search

titusjan / argos

Argos: a data viewer that can read HDF5, NetCDF4, and other file formats.
GNU General Public License v3.0
176 stars 26 forks source link

fixed line plot, heat map and added abilitiy to build msi installer #22

Closed franzhaas closed 2 years ago

titusjan commented 2 years ago

Thanks for the PR but it seems to do multiple things.

1) fixed line plot, heat map. Can you explain what this does? What needs to be fixed? 2) added ability to build msi installer. I appreciate the work but I have plans to do this myself using PyInstaller since I have good experience with it. I hope you didn't put too much effort in it.

franzhaas commented 2 years ago

@1 On my win10 setups accessing the heatmap / line plot feature caused an error and no plot. The change that improved my experience was to import QtCore and QtWidget.

This was done at places that already had this code, but commented out.

But my memory might fool me here...

@2 The gist is to uses importlib to look for resources, and not to traverse directory trees.

This makes life easier for installers, as that allows them to place the information wherever it is practical. This makes single file executables possible as they, by definition, can not have a directory tree.

titusjan commented 2 years ago

@1 On my win10 setups accessing the heatmap / line plot feature caused an error and no plot.

This has now been fixed in another PR.

@2 The gist is to uses importlib to look for resources, and not to traverse directory trees.

Argos is a bit unusual with its many optional dependencies though. I'll let you know if I made an installer.