search

titusjan / objbrowser

GUI for Python object introspection
MIT License
129 stars 16 forks source link

Add support for PySide2 #4

Closed NicoRyberg closed 3 years ago

NicoRyberg commented 4 years ago

Add support for PySide2 binding by setting the QT_API environment variable to 'pyside2'.

Change-Id: I9d10b26c161850b86a2aa2c9bb67924ea2778f9a

amal-khailtash commented 3 years ago

Can objbroswer depend on qtpy as a dependency instead of adding it directly in the project? qtpy already supports PySide2

NicoRyberg commented 3 years ago

Hello @amal-khailtash, that would be a better approach!

titusjan commented 3 years ago

@NicoRyberg sorry for not responding earlier and thank you for your PR.

The reason why I included qtpy in the project was because of issue 119 in qtpy. However, this issue has been resolved for years now, so I decided to follow @amal-khailtash suggestion and make qtpy a regular dependency.

I made a new release (1.3.0) that automatically installs qtpy. With this I think I can close this PR.