search

titzer / virgil

A fast and lightweight native programming language
1.23k stars 44 forks source link

Check for test failure for each internal target #210

Closed k-sareen closed 10 months ago

k-sareen commented 10 months ago

Closes #208.

k-sareen commented 10 months ago

The issue was that the v3i target was failing but we were returning the exit code for the v3i-ra-ma internal target. We should do a failure check for each of the commands to ensure we report failures correctly and fail as soon as possible.

I was a bit lazy and added the exit code check to the execute_tests function, but maybe a clearer/better solution would be to add the exit code checks wherever progress is being called.

k-sareen commented 10 months ago

If you checkout to the offending commit (https://github.com/titzer/virgil/commit/4868eae743511698439e179983521350dd5a9b90) and then cherry-pick this fix, you'll find it fails correctly as expected.