tiuweehan / pe

0 stars 0 forks source link

Prerequisities feature do not work for 'equivalent' modules #8

Open tiuweehan opened 5 years ago

tiuweehan commented 5 years ago

CS1101S is a prerequisite for CS2040 but this is not reflected as the prerequisites are shown as "CS1010 and its equivalent"

Screenshot 2019-11-15 at 4.59.27 PM.png

Screenshot 2019-11-15 at 4.58.41 PM.png

nus-pe-bot commented 5 years ago

Team's Response

Thank you for the feedback, but as of the current implementation, searching by prerequisite and preclusions does indeed not account for similar modules due to the lack of an implementation to detect if a string is indeed a module code or just a string. Given that these information are derived directly from NUSMods and there are often vague prerequsites, such as "Pass A level math" which is difficult to decipher and utilitse in search, it is rather difficult to address on time before V1.4 and this problem is left to be solved in the future. However, this does highlight a rather glaring issuse that does affect the accuracy of the seach which definitely needs addressing sooner or later.