search

tiwarylab / amino

Automatic Mutual Information Noise Omission
MIT License
14 stars 3 forks source link

update with modern wrapper and style #7

Closed k9cdt closed 1 week ago

k9cdt commented 2 weeks ago

This PR comes with two major changes.

  1. I rewrote the CLI with a typer, which provides a more modern and robust command line interface.
  2. For a big part of the kernel, rewrote with numpy style and in a more pythonic way to enhance readability.
k9cdt commented 2 weeks ago

I addressed most comments with a new commit except for the add_OP function. The if statement makes it hard to consolidate those matrix constructions without introducing a new function.

I agree with adding more tests. Maybe some synthetic data for sanity checks.