tixsys / esteid

Automatically exported from code.google.com/p/esteid
2 stars 0 forks source link

[browser plugin] whitelist dialog gets stuck #107

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. Install ID-Card packages
2. Open www.eesti.ee
3. Try to sign a document

What is the expected output? What do you see instead?

First, there is not functioning entry in default whitelist (id.eesti.ee instead 
of www.eesti.ee). But more important, when I add www.eesti.ee to whitelist, 
nothing happens. I cannot sign. I expect either to be able to sign the document 
immediately after adding an entry to whitelist or get instructions about the 
need to reload the page. Of course it would be normal, if this happened all 
automatically.

What version of the product are you using? On what operating system?

Latest from repository, Linux Mint 9 Isadora.

Original issue reported on code.google.com by boamaod on 5 Oct 2010 at 12:02

GoogleCodeExporter commented 9 years ago
And the browser You are using?
Only Firefox has Java tag converter that is required to sign documents
at eesti.ee

Original comment by ant...@gmail.com on 6 Oct 2010 at 1:30

GoogleCodeExporter commented 9 years ago
r3127 should of added www.eesti.ee to the default whitelist.
Since that commit was made before the latest source releases were created, can 
You please verify what packages You are using. If You are still on the 
repository from ftp.smartlink.ee, please upgrade to the latest Ubuntu PPA and 
re-test.

Thank You!

Original comment by ant...@gmail.com on 6 Oct 2010 at 1:34

GoogleCodeExporter commented 9 years ago
Unfortunately there is currently functionality to force the browser to reload a 
page from a plugin. And it would be bad idea to implement it. Most sane 
websites have a button that triggers the signing operation and the user can 
click on it again after a failed signing operation. The plugin will report 
error back to JS. Eesti.ee is not one of them, their signing code is ancient, 
so You could probably report the reload issue to them.

Original comment by ant...@gmail.com on 6 Oct 2010 at 1:37

GoogleCodeExporter commented 9 years ago
I use Firefox. Www.eesti.ee problem was solved.

I do not agree with the comment 3. It is normal use flow:

1) Show the message that site tries to access ID-card.
2) User clicks on button, adds the site to whitelist and presses "OK".
3) Signing fails and and nothing happens.

For user, it seems there was no positive result for the actions. Instead of 
"Nothing happens" there should be:

a. Message that user should reload the page.
b. Message that user should look for "Try again" button.
c. Automatic reload, if it is possible.
d. ...

Never mind the technical issues, I'm talking about users point of view.

Original comment by boamaod on 7 Oct 2010 at 12:27

GoogleCodeExporter commented 9 years ago
Well pop-ups suck, also page reload can break JS so the best way would be to
add a warning to whitelist editor that is displayed after the user adds some 
sites
to whitelist.

Can You please help with that? We are short of hands around here ;)

The file You are looking for is 
esteid-browser-plugin/trunk/X11/whitelistdialog.ui

It can be opened with glade3.

If the Linux solution is successful, the same functionality must be added
to Mac and Win32 UI-s (esteid-browser-plugin/trunk/Mac, 
esteid-browser-plugin/trunk/Win).

Original comment by ant...@gmail.com on 8 Oct 2010 at 7:56

GoogleCodeExporter commented 9 years ago
I want to clarify that my proposal is to add a message space to whitelist 
dialog.
And after user adds a site, a warning message is displayed at this space.
This way the user is not annoyed with pop-ups. Page reloads can break things.
What is needed:

1. Implementation of the space for all 3 UI-s
2. Program logic to display the message at this space
3. Program logic to display "reload warning" when a site is added
4. The texts of the warning in 3 languages. Starting with English.

Original comment by ant...@gmail.com on 8 Oct 2010 at 7:59

GoogleCodeExporter commented 9 years ago
Made a first and simple move for Linux UI. For some explanations, see 
http://groups.google.com/group/esteid-devel/browse_thread/thread/a6d5ec01cc6f265
0 (in Estonian). It needs to be decided, how and where exactly should this 
message space be created.

Original comment by boamaod on 23 Oct 2010 at 1:20

Attachments: