search

tiy-houston-q4-rails / day-8

0 stars 1 forks source link

Astrid's BlackJack (almost) #10

Open astridw opened 10 years ago

astridw commented 10 years ago

I stopped with the classes cause I kept confusing myself, but now I can't get my game to end properly. the file is blackjack4.rb

https://github.com/astridw/day8

astridw commented 10 years ago

I am still working on getting the bugs out, but this one is working (sorta).

git@github.com:astridw/day8.git

jwo commented 10 years ago

@astridw Astrid -- please post the code you'd like me to review. Remove any commented out code.

Other comments:

1) Show me the cards themselves, not just that I have 20 2) If I stay with 18 (for example), it doesn't end the game 3) I would keep the run loop (hit or stay) as one thing, and then determine the winner after the run loop has stopped

astridw commented 10 years ago

ok— i will make the changes and resend. I tried to determine the winner but was having some problems. i will attempt that again.

Thanks for the feedback

Astrid On Oct 9, 2014, at 9:01 AM, Jesse Wolgamott notifications@github.com wrote:

@astridw Astrid -- please post the code you'd like me to review. Remove any commented out code.

Other comments:

1) Show me the cards themselves, not just that I have 20 2) If I stay with 18 (for example), it doesn't end the game 3) I would keep the run loop (hit or stay) as one thing, and then determine the winner after the run loop has stopped

— Reply to this email directly or view it on GitHub.

astridw commented 10 years ago

This one is much better and working, although I kept running into issues trying to show the face card vs the value so i showed the value

https://github.com/astridw/day8/blob/master/blackjack5.rb

jwo commented 10 years ago

Looks super awesome! Well done. 

— Sent from Mailbox

On Sat, Oct 11, 2014 at 2:46 PM, astridw notifications@github.com wrote:

This one is much better and working, although I kept running into issues trying to show the face card vs the value so i showed the value

https://github.com/astridw/day8/blob/master/blackjack5.rb

Reply to this email directly or view it on GitHub: https://github.com/tiy-houston-q4-rails/day-8/issues/10#issuecomment-58762037