tiyd-python-2015-08 / assigments

11 stars 10 forks source link

08 -- what-to-watch -- Will Butts #138

Closed Shea-Wolfe closed 9 years ago

Shea-Wolfe commented 9 years ago
Shea-Wolfe commented 9 years ago

@jamesmallen @powder-river

https://github.com/Shea-Wolfe/what-to-watch

I wanted to get something up. I wasn't sure how to test methods so I just commented out the classes and tested them as functions. My README needs to be updated but I will do so this weekend.

Update: I thought about it and remembered how classes worked. Now test suite is working with classes and everything. Time for bed.

Shea-Wolfe commented 9 years ago

@jamesmallen @powder-river

Program has been updated with key functionality. Currently my function to get a recommendation from a similar user only suggests a highly reviewed movie that the similar user has seen but the current user hasn't, it doesn't take the similar users actual rating into account.

My readme needs to be updated (badly) and I need to add to my testing suite and ensure my code isn't terribly venerable to bad input. I will likely be focusing on that tomorrow (Sunday).

Shea-Wolfe commented 9 years ago

@jamesmallen @powder-river

Ok, did some more work with my program. Realized I could store multiple similar users by setting a minimum similarity rather than only keeping the most similar. Used that to pick movies each of those users liked and taking the rating of that movie (from all ratings) multiplied by their euclidean distance (since if I did their personal rating it would probably always be a 5, thus the most similar would always be returned). I think this satisfies the requirement to get similar users and use the distance from them to help decide what to watch.

Readme is a few hours out of date but the run instructions still work.

https://github.com/Shea-Wolfe/what-to-watch

powder-river commented 9 years ago

@Shea-Wolfe looking good will, I mean we could talk some UI things to make to a little more clear what's going on but all and all strong submit. It doesn't look like you tested "every" method, however it looks like you tested quite a bit. Good submit will