tizbac / pmoxs3backuproxy

Proxy written in golang that will emulate a PBS server and work on one or more S3 buckets
GNU General Public License v3.0
49 stars 4 forks source link

Checksums in re-used index files wont match #59

Closed abbbi closed 2 months ago

abbbi commented 2 months ago

I noticed this after implementing check in GC to verify the checksums of the index files it processes. In case an backup is started with reuse-csum set, the sha265 checksum in the index file does not match the checksum set via metadata tag for the indexfile itself (because index is reused from indexed/ folder. (#60)

abbbi commented 2 months ago

there seems to be a little bit more off here. because for me every third incremental backup is failing .. i think since merge of commit 4da4d163a58f7dd9ddad01764ec9cf591b06ec5d something is off.

abbbi commented 2 months ago

ive reverted the commit for now, until i have found out where exactly the problem is. After revert i can run multiple incremental backups again and the checksums are OK during GC. I guess i missed something of the logic while converting the function to use writeBinary and it produced an index thats not sane.