search

tizbac / proxmoxbackupclient_go

In development proxmox backup client written in golang, aimed at windows compatibility
GNU General Public License v3.0
195 stars 15 forks source link

refactoring request #25

Open egandro opened 6 months ago

egandro commented 6 months ago

Great work!

I would like to make a suggestion.

Can we refactor main.go and have a main.go (having a main and flags) and a pbsclient.go and add C-linkage on top of this?

My intention is to make this library work as foundation to other software e.g. an electron client.

Go is a very nice language for that! Rust is such a pain in butt to add C level linkage to this.

Please confirm that you love the idea and I will to the work.

Thx.

tizbac commented 6 months ago

Hi, if you want to, you are welcome to do it, I don't think I have time until next week

Il mer 8 mag 2024, 20:37 egandro @.***> ha scritto:

Great work!

I would like to make a suggestion.

Can we refactor main.go and have a main.go (having a main and flags) and a pbsclient.go and add C-linkage on top of this?

My intention is to make this library work as foundation to other software e.g. an electron client.

Go is a very nice language for that! Rust is such a pain in butt to add C level linkage to this.

Please confirm that you love the idea and I will to the work.

Thx.

— Reply to this email directly, view it on GitHub https://github.com/tizbac/proxmoxbackupclient_go/issues/25, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABBV6Q5VCUBTJLV4OHHKEDZBJWILAVCNFSM6AAAAABHNPPFXCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4DMMRRGMYTONI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

egandro commented 6 months ago

Also - related to that.

If we go library, can we go LGPL for the License?

I think that makes sense.

tizbac commented 6 months ago

Ok for me but i have to ask who has contributed to sign that change will take some time

egandro commented 6 months ago

So everybody in for the LGPL change?

scheibling commented 6 months ago

Having this code to use as a library would be amazing. We're in the process of building a custom PXAR library (reading through your code has been a huge help in figuring some parts out), only for the archive format though and not the communication with PBS.

The plan is to offer a more consistent/easy interface for reading/writing data to/from PXAR Archives from disk or data alike, if you wanna use the library or copy out some code to use that might make save some time for you. It's gonna be released under the LGPL as well

If everything goes as planned, we'll have an early version released in 1-2 weeks. We have written a lot more specific docs about the file format as well and will try to talk to Maurer about extending the official docs

Edit: A bit later than expected, but now we have some initial code along with some better documentation on the format. This is currently only for the PXAR and PCAT1-formats, and not the PBS communication https://github.com/scheiblingco/go-pxar