tizerk / ytiz

An MP3 downloader for YouTube and SoundCloud with no annoying ads or popups
https://ytiz.xyz/
GNU General Public License v3.0
31 stars 2 forks source link

Some links being downloaded as empty m4a files #4

Closed chdorter closed 2 months ago

chdorter commented 2 months ago

Describe the bug Some videos are being downloaded as m4a files with a size of 256 bytes. The filename is correct. The preview appears correct. No numeric percentage progress appears, it just downloads instantly. Using default settings (MP3, 128kbps) Using basic YouTube links without parameters appended

To Reproduce Steps to reproduce the behavior:

  1. Open the page
  2. Paste a YouTube link - eg: https://www.youtube.com/watch?v=8l75Z8wil_U
  3. Click download

Expected behavior The full size MP3 file should download.

Desktop (please complete the following information):

Great app!! Thanks!

tizerk commented 2 months ago

Thanks for bringing this up! The yt-dlp version I was using was 2024.07.08, which has a bug with the YouTube extractor. I've updated the backend to 2024.07.09, which should fix the issue. I'll keep monitoring to make sure everything is working again.

EDIT: Okay, that wasn't the issue. I'll look into this deeper.

tizerk commented 2 months ago

It seems yt-dlp was incorrectly labelling the files as .M4A, even when they were supposed to be .MP3. I've forced the backend to rename M4A files to MP3, which should now fix the issue. I'll keep monitoring to make sure everything is working again.

chdorter commented 2 months ago

Great! Looks like it's working smoothly now. Thanks for looking into this. Cheers again for making this useful tool