search

tiziano88 / elm-protobuf

protobuf plugin for elm
https://package.elm-lang.org/packages/tiziano88/elm-protobuf/latest/
MIT License
94 stars 28 forks source link

infix functions in generated decoders #10

Closed ericgj closed 6 years ago

ericgj commented 6 years ago

Given infix functions are problematic in Elm at the moment (they cause conflicts if any 2 libraries define the same function), and may be going away except for in core libraries in 0.19, would it be possible to replace the (<$>) and (<*>) in the generated decoders?

(Sorry if this is already done, I have not looked at the implementation, just the expected output in the tests.)

tiziano88 commented 6 years ago

Yes I agree, we should probably use a style similar to https://github.com/NoRedInk/elm-decode-pipeline instead of the infix operators, I may get to it at some point but contributions are welcome :)

ericgj commented 6 years ago

Just discovered you already did this ! The expected output in the go_tests still have the infix functions, don't know if these are not used anymore or need to be updated.