search

tiziano88 / elm-protobuf

protobuf plugin for elm
https://package.elm-lang.org/packages/tiziano88/elm-protobuf/latest/
MIT License
94 stars 28 forks source link

List decode fix #5

Closed donpdonp closed 7 years ago

donpdonp commented 7 years ago

I believe this is a fix for issue #4. The decode logic said somethink like object is an array when object.element is the array.

tiziano88 commented 7 years ago

Hey, thanks for the PR! I realised the build was not really working, so I fixed it now; could you rebase on top of master to make sure everything still works?

donpdonp commented 7 years ago

It does fix the problem I'm seeing but I'm not 100% certain of its correctness, largely due to this elm code being at a higher level of 'functional'ness than I normally code at :).

I dont understand the request to rebase. the fork was created from master - is there something else I need to do? "donpdonp wants to merge 1 commit into tiziano88:master from donpdonp:master"

tiziano88 commented 7 years ago

I added a test case for the issue you described (which was indeed failing), and verified that your PR fixes it! Good catch! Thanks so much for contributing, and finding time to fix the code, it is much appreciated! Looking forward to more contribs :)