Bigarray - Githubissues

tizoc / ocaml-interop

OCaml<->Rust FFI with an emphasis on safety.

MIT License

134 stars 21 forks source link

Bigarray #26

Closed g2p closed 2 years ago

g2p commented 3 years ago

This exposes Bigarray.Array1 to Rust, with a Borrow implementation that allows read-only access to Bigarrays without copies.

(Marking as draft for cosmetic reasons: I'd like to flatten the module structure, and there will be fewer conflicts if I can do that after other PRs are merged)

g2p commented 2 years ago

I've updated things for API changes and documented some safety assumptions. Also, it's probably okay to keep bigarray-related things in one file. This is no longer a draft, please review!

tizoc commented 2 years ago

@g2p thank you! I will try to go over this one soon.

tizoc commented 2 years ago

Hi @g2p, sorry it took me so long to get to this (too much of other stuff keeping me busy).

It looks good to me. Just a few things:

Add an entry to the CHANGELOG (something like, "Support for OCaml's Bigarray.Array1 values (by @g2p)" in the "Added" section)
Move the different fragments of code in bigarray.rs to where they belong (I saw you already have organized this with comments already specifying that).
Finally squash everything into a single commit.

After merging I will publish a new release.

g2p commented 2 years ago

Apologies for the long delay. I've addressed the comments (moved things, added to the changelog, squashed).

tizoc commented 2 years ago

@g2p merged. Thank you!