tizu69 / ntl-redone

Create NTL (No Train Limits [almost]), but redone. More coming soon
MIT License
44 stars 12 forks source link

Crash when previewing new track segment (45-slope & 90-degree-bend) #23

Open Tachrayonic opened 1 year ago

Tachrayonic commented 1 year ago

A crash isn't really surprising here, but since even Shalz was running into it I thought I'd document my findings here. This crash immediately kicks the player out of the world, and will kick them upon relogging as the crash conditions will still be met.

There are two requirements for the crash to happen:

Note that you do not need to right-click to place the new segment, simply getting the preview to appear for such a track segment will usually crash your game immediately. There are some segments that meet these conditions that don't crash, usually very short segments.

Now, to deal with this crash and get back into your world you need to get your player looking away from the offending location.

Hope this helps!

Tachrayonic commented 1 year ago

crash-2023-01-03_16.46.56-client.txt Crash log from such a crash

Tachrayonic commented 1 year ago

2023-01-03_17 05 13 Just examined this a bit more thoroughly, it is more directional than I realized.

Connecting from the Red flat track pieces to the Green sloped track pieces Works every time Connecting from the Green sloped track pieces to the Red flat track pieces Crashes every time

Replacing the Red pieces with slopes Worked every time, so Slope -> Slope seems to work every time Rotating the entire structure had no effect, so it doesn't seem to be limited by rotation

It seems like you simply cannot connect from a slope to a flat tile around a 90-degree bend. I thought it was worse than that, but that's what my data shows.

Schematic for my test rig track_ntl_crash_test.zip

tizu69 commented 1 year ago

Oh my god, thank you so much for all this information! This will definitely be patched in the next release, most likely by reintroducing the error message when trying to start from a slope (unless I can somewhat easily fix the bug directly). While I'm still on my holidays, I'll try to fix this as soon as possible, as I want to avoid all crashes. Honestly, thanks. This helps me so much!

github-actions[bot] commented 1 year ago

This issue has been marked as stale because it has been inactive for 3 weeks. It will be closed if it remains inactive for another 3 weeks.