search

tizzle / aframe-orbit-controls-component

An Orbit Controls Component for A-Frame VR
https://tizzle.github.io/aframe-orbit-controls-component/
MIT License
75 stars 25 forks source link

panning only works in two axes #15

Closed MannyMeadows closed 7 years ago

MannyMeadows commented 7 years ago

Panning in the z-axis seems to have broken. Panning horizontally will only work in the x-axis.

Thanks for your efforts.

tizzle commented 7 years ago

Hey @MannyMeadows,

i made a short video while trying to figure out how to fix this. You can see it here: http://eightdaysaweek.cc/files/AOC_PANNING.mp4

Panning can be achieved by pressing ctrl or by using three fingers on a touch device. Is this not the intended panning behaviour? What did you expect?

Thanks and Cheers,

Till

MannyMeadows commented 7 years ago

Thanks for your reply.

I'm afraid your video only demonstrates the X & Y axes. If you rotate the scene by 90 degrees and try panning along the Z axis, you'll find that it is restricted to one horizontal axis only - panning along the Z axis will result in a zooming behaviour.

All axes were panning fine before the last update.

tizzle commented 7 years ago

Ok, i think i understand now.

With the last update there was some serious rewrite of the internal behaviour. This should have rather been a new feature-version instead of just a patch-version. I guess i got to learn that, i'm quite inexperienced with maintaining a public project so far :)

Thanks for your explanation. I will look into this!

tizzle commented 7 years ago

Hey @MannyMeadows,

i just pushed a new version that should fix this. Please check!

Cheers

Till

MannyMeadows commented 7 years ago

Perfect. Thanks for adressing this so quickly.

Keep up the good work.

Mark