Orbit controls break if using an <a-assets> container

flimshaw commented 7 years ago

I just confirmed this happens on the example code as well. To replicated, just drop an element into the top of your scene, with individual nested assets or not. The orbit controls will no longer work, and no error messages are thrown in the console. Very strange, any ideas where to look for causes?

[Sorry the gif is in slowmo for some reason]

orbit-controls-bug

tizzle commented 7 years ago

Hey @flimshaw,

nice catch. Do you use latest Aframe? Might be connected to the bump to 0.6.0. I haven't had the time to check.

Since i changed the examples to the standard aframe plane with box, cylinder and sphere, and i don't use assets in the examples anymore, this must have slipped through. I will have a look and get back to you!

Cheers

Till

flimshaw commented 7 years ago

I was running 0.5.0 when I sent the bug, but I just tried it on 0.6.0 and the behavior seems to be the same. Thanks!

tizzle commented 6 years ago

Hey,

we released a new version of the orbit-controls today. I then tested with version 0.7.0 and it seems to work for me. I added a new example to github. Can you confirm this works for you? What kind of assets are you using?

<html>

<head>
  <title>A-Frame Example Component - Basic</title>
  <script src="../build.js"></script>
</head>

<body>
  <div id="aframe">
    <a-scene id="a-scene">

      <a-assets>
        <img id="sky" src="sky.jpg">
      </a-assets>

      <a-entity
        id="camera"
        camera
        position="0 2 5"
        orbit-controls="
          target: #target;
          enableDamping: true;
          dampingFactor: 0.125;
          rotateSpeed: 0.25;
          minDistance: 3;
          maxDistance: 100;
        "
        mouse-cursor="">
      </a-entity>

      <a-entity id="target">
        <a-box id="box" position="-1 0.5 1" rotation="0 45 0" color="#4CC3D9"></a-box>
        <a-sphere id="sphere" position="0 1.25 -1" radius="1.25" color="#EF2D5E"></a-sphere>
        <a-cylinder id="cylinder" position="1 0.75 1" radius="0.5" height="1.5" color="#FFC65D"></a-cylinder>
        <a-plane position="0 0 0" rotation="-90 0 0" width="4" height="4" color="#7BC8A4"></a-plane>
      </a-entity>

      <a-sky src="#sky"></a-sky>

    </a-scene>
  </div>

</body>

</html>

tizzle commented 6 years ago

closing due to inactivity

tizzle / aframe-orbit-controls-component

Orbit controls break if using an <a-assets> container #22