Closed pl4nty closed 1 year ago
Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.
@pl4nty I believe the bug is on your end from the logs
/usr/bin/git submodule status
fatal: no submodule mapping found in .gitmodules for path 'shapes/shapes'
-e9831fb26c16c10abd67c073c839a12d32495ec6 ataxx/ataxx
-17acdf5916014882d76abdc79096b8811ad7b9b9 aussiebb/aussiebb
-a553dabfe0c739f48619d372aaedffddbb39553f codeworld/codeworld
-27d95f38d04f85f1ad211db940f00d83a6749b5d excel2latex/excel2latex
-d45c87a0ccdfc0c48971c5eb830d9258d17ae3ff jsonwebtoken/jsonwebtoken
-d342eea01b41c69fc8c67da5488df4ab3fe418f4 jwtplayground/jwtplayground
-2504208ba9428b6c75ebe56c1fcef63660ea05e8 mac_apt/mac_apt
-9f5ecb39e8eb06231ab51e7eb1a3594235a1c30a mha/mha
-e227102b3ec58089fec26cb9875a802c95e529ff openssl-webterm/openssl-webterm
Ensure that there are no errors running git submodule status
to resolve the issue.
@pl4nty We can potentially relax this requirement if this is an expected outcome but keep in mind any invalid submodule mapping would exclude that submodule from change detection. The reason this passed in v35 was that such checks weren't introduced.
@jackton1 apologies, that error is expected behaviour due to a separate token issue I resolved.
here's a v36 test case with all submodules working, but changes still aren't detected: https://github.com/pl4nty/containers/commit/990940c6b8b0be220b3d80b590b41cfda51f9738/checks?check_suite_id=13844342325
@pl4nty Can you run the workflow with debugging enabled to get the logs?
Maybe v36 is only checking the first submodule (anudegreeapp)?
I just saw v37 has GitHub API support, might upgrade to that. It's a monorepo so cloning with depth 0 is pretty slow
Okay, I found the bug, pushed a fix which would be release momentarily.
@pl4nty This should be resolved in v37
@jackton1 I've confirmed it's resolved, thanks so much for your help and quick responses
Is there an existing issue for this?
Does this issue exist in the latest version?
Describe the bug?
After upgrading from v35 to v36, changes in submodules are no longer detected in my repo. Reverting to v35 resolved the issue.
To Reproduce
v35 run
v36 run
What OS are you seeing the problem on?
ubuntu-latest or ubuntu-20.04
Expected behavior?
Detect changes in submodules
Relevant log output
Anything else?
No response
Code of Conduct