search

tj-actions / install-postgresql

:octocat: Github action to install PostgreSQL
MIT License
4 stars 1 forks source link

support postgresql v11-16 #15

Closed BrennanColberg closed 10 months ago

BrennanColberg commented 10 months ago

PostgreSQL v16 was publicly released this last September, but this action (and therefore by extension tj-actions/pg-dump) hard-caps users to installing v15 at the highest.

This PR modernizes that limitation, allowing users to install postgresql v16.

It also causes the tests to stop installing postgresql v10 (though it still allows for users to specify v10 for backward-compatibility purposes), because the homebrew-based installation tests on macOS now fail when attempting to install v10, with this message:

Error: postgresql@10 has been disabled because it is not supported upstream!

I believe this change should prompt a new version release, or at least a re-release of v2, so that other actions (like tj-actions/pg-dump) can be updated to work with v16 properly.

BrennanColberg commented 10 months ago

Thanks for implementing a fix, could you ensure that the test covers your changes if applicable.

It does; tests have been updated to cover v16 installation. I would note that the currently queued-up tests may not pass because they are based on the main branch checks and include the matrix entry of (macos-latest, 10). All installations of v10 on macOS in checks are failing nowadays, even on a clean fork of this repository, because Homebrew appears to see something wrong with the package.

jackton1 commented 10 months ago

Thanks for implementing a fix, could you ensure that the test covers your changes if applicable.

It does; tests have been updated to cover v16 installation. I would note that the currently queued-up tests may not pass because they are based on the main branch checks and include the matrix entry of (macos-latest, 10). All installations of v10 on macOS in checks are failing nowadays, even on a clean fork of this repository, because Homebrew appears to see something wrong with the package.

Hi @BrennanColberg, the test are based on the changes you’ve made, so I wouldn’t worry too much about that.

jackton1 commented 10 months ago

@all-contributors please add @BrennanColberg for code, docs and test

allcontributors[bot] commented 10 months ago

@jackton1

I've put up a pull request to add @BrennanColberg! :tada: