tj / axon

message-oriented socket library for node.js heavily inspired by zeromq
MIT License
1.5k stars 155 forks source link

Support for multiple peers needs improvement #141

Open Schoonology opened 9 years ago

Schoonology commented 9 years ago

While I love the idea of a pure-Node alternative to ZeroMQ and the like, there are a number of areas that need some improvement before it can replace it for dynamic clusters with nodes coming in and out periodically:

I could certainly be misunderstanding the code, but tinkering in the guts confirms these concerns. Thoughts? How would y'all feel about my fixing some (or all) of these?

tj commented 9 years ago

Hmm I imagine a clean close via some command would be enough to signal that the peer isn't coming back. That wasn't something I needed personally but I agree it would be good to have!

I haven't checked out the code in a while now but I think the rest sounds about right as well

thelinuxlich commented 9 years ago

+1