tj / commander

The complete solution for Ruby command-line executables
http://visionmedia.github.com/commander
MIT License
1.09k stars 64 forks source link

Ruby warning: circular require considered harmful #84

Closed ralfclaassens closed 9 years ago

ralfclaassens commented 9 years ago

The warning below shows that there is something wrong in the way of 'require' in this commander-gem. Would be nice to clean this up.

ruby/2.1.1/ruby/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55: warning: loading in progress, circular require considered harmful - /.gem/gems/commander-4.2.1/lib/commander.rb
from packager:23:in  `<main>'
from packager:23:in  `load'
from /.gem/gems/packaging-1.1.1.pre/bin/packager:3:in  `<top (required)>'
from /ruby/2.1.1/ruby/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in  `require'
from /ruby/2.1.1/ruby/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in  `require'
from /.gem/gems/packaging-1.1.1.pre/lib/generator_command.rb:3:in  `<top (required)>'
from /ruby/2.1.1/ruby/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in  `require'
from /ruby/2.1.1/ruby/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in  `require'
from .gem/gems/commander-4.2.1/lib/commander.rb:33:in  `<top (required)>'
from /ruby/2.1.1/ruby/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in  `require'
from /ruby/2.1.1/ruby/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in  `require'
from /.gem/gems/commander-4.2.1/lib/commander/methods.rb:1:in  `<top (required)>'
from /ruby/2.1.1/ruby/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in  `require'
from /ruby/2.1.1/ruby/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in  `require
ggilder commented 9 years ago

Linking https://github.com/tj/commander/pull/87