memory leak with Nunjucks template

tj / consolidate.js

Template engine consolidation library for node.js

3.48k stars 358 forks source link

memory leak with Nunjucks template #291

Open dail opened 6 years ago

dail commented 6 years ago

When i do stress testing, I have found an memory leak issue with Nunjucks's renderString method, which is called in this library. I have opened an issue in Nunjucks procect.

With the renderString method, we can't use relative path in template. When I replace it with render method of Nunjucks, no memory leak, relative path can also works correctly. I suggest use render method instead of renderString in this library.

edevil commented 5 years ago

Is this still a problem?

titanism commented 1 year ago

We have forked this repository for maintenance and released it under @ladjs/consolidate, see https://github.com/ladjs/consolidate.js. We have merged PR's and updated it for email-templates. Please click the "Watch" button to get notified of all releases at https://github.com/ladjs/consolidate.js. Thank you 🙏

PR welcome at the new repo once new release is published today!