Closed akhoury closed 2 years ago
@akhoury thanks for the PR. I'll try to get this reviewed soon.
There is a temporary dependency from a github fork instead of a published npm module, the PR has been approved, just waiting for it to be published.
Thanks for this information, it'll probably be better to wait until the other PR is published.
I see that the build on Node 4 and Node 6 are failing, looks like it's the github dependency thing, ok, i guess we can wait, thanks
@akhoury @doowb what is the status on this? It would help me a lot on the project I am working on. Thanks!
@doowb I removed the github fork dependency so it's now using a published version of the vue-pronto module, but not the latest one because of some of their breaking changes.
but it's not still not working in Node 4 :/ not sure how hard of a requirement that is
@tmasrat if you absolutely need this now and can't wait for this PR to be merged and published, in your package.json
you can point consolidate.js
dependency to use my github fork with a specific commit hash so you wont to use master
and risk breaking anything every time i make a change
"consolidate.js": "github:akhoury/consolidate.js#7c1ffce0c68aa85c41f490c4eafe8b3d62a3e72c",
@akhoury thanks! I will explore other options but if it comes down to it, I will use your fork.
Also looking forward to this. Many libraries have dropped node <6 support already, in my opinion it would be okay to go for that here too.
@doowb any chance this will be merged soon?
Fix conflicts and ping me back
(and resubmit a new PR)
There is a temporary dependency from a github fork instead of a published npm module, the PR has been approved, just waiting for it to be published.