tj / consolidate.js

Template engine consolidation library for node.js
3.48k stars 357 forks source link

Improve "Supported template engines" in README.md #322

Closed A-312 closed 4 years ago

A-312 commented 5 years ago

I made this table for my npm package. (I think it can interest you)

doowb commented 5 years ago

This looks great. I just merged in another PR that caused this to be conflicted. Will you update the table with the new update?

A-312 commented 5 years ago

I'll do, ping me when I can

A-312 commented 5 years ago

@doowb Hi, this PR is ready , are you waiting for something ?

doowb commented 5 years ago

are you waiting for something

No, thanks for the ping, I've just been busy. I'll take a look this weekend.

A-312 commented 4 years ago

@doowb You forgot it 😜

doowb commented 4 years ago

Thanks for the reminder... again ;)

nebrelbug commented 4 years ago

Hey @doowb and @A-312, it looks like when you created the new table you left out Squirrelly, which had just gotten added in #317.

Should I make a pull request to add it? Thanks!

doowb commented 4 years ago

Should I make a pull request to add it?

Yes please! Sorry for overlooking it when merging.

A-312 commented 4 years ago

@nebrelbug Sorry ! I make a mistake in my rebase :(

nebrelbug commented 4 years ago

@A-312 @doowb just created the pull request! See #326 😄