search

tj / frontend-boilerplate

webpack-react-redux-babel-autoprefixer-hmr-postcss-css-modules-rucksack-boilerplate (unmaintained, I don't use it anymore)
2.93k stars 268 forks source link

Chore/dry up action names #46

Closed thebigredgeek closed 8 years ago

thebigredgeek commented 8 years ago

@tj thoughts here? Got started building something and saw this. I figured it was kind of a no brainer PR

tj commented 8 years ago

I like the direction of #35 but it just needs a better name for the dir or to remove the nesting I think. I think constants are kind of unnecessary in js though, I can say that I've literally never "accidentally" re-assigned one. I think if we're going to add constants instead of just using strings they should be in the same file so it's not too annoying to reference, since you can easily import the wrong name and end up with it just giving you undefined

thebigredgeek commented 8 years ago

Yeah I think that would also work too. Having it all in a single file definitely has it's own benefits. For a boilerplate that probably makes sense anyway. You only break stuff out into multiple files if the project gets HUGE. I'll close this