search

tj / git-extras

GIT utilities -- repo summary, repl, changelog population, author commit percentages and more
MIT License
17.29k stars 1.21k forks source link

Include git-find #587

Open Natureshadow opened 7 years ago

Natureshadow commented 7 years ago

Dear git-extras maintainers,

I'd like to propose to include the git-find tool form mirabilos/git-find in git-extras. It is a really handy tool allowing GNU find-like searching through paths known to Git, but is too small to be packaged alone.

anatolyborodin commented 7 years ago

Well, looks like the MirOS license allows it.

Natureshadow commented 7 years ago

Sure. It's more-or-less MIT/Expat.

Natureshadow commented 7 years ago

Should I do a pull request with it? Should I copy it in then, or do a real subtree-merge?

Upstream would acknowledge merging into git-extras.

spacewander commented 7 years ago

In my opinion, a simple copy is enough(Don't forget to write docs!).

@hemanth @qw3rtman @nicolaiskogheim Any suggestions?

Natureshadow commented 7 years ago

In my opinion, a simple copy is enough(Don't forget to write docs!).

Upstream stated that he wouldn't mind moving upstream development to git-extras and drop the seperate repository. I like keeping the history, in that case.

Natureshadow commented 7 years ago

I jsut notice that git-extras seems to mandate use of bash… If so, why's that, and can a ksh script be included?

spacewander commented 7 years ago

Bash is the most common shell, shipped by Linux and Mac OS as default choice. Stick to bash, therefore users can get the features out of box. A ksh need to be rewritten with bash, if we want it to be a part of git-extras.

Natureshadow commented 7 years ago

Bash is the most common shell

Now this is simply not true.

ksh (mksh) is the default shell on many BSDs and on some 80 million or so mobile devices (Android).

Sticking to bash is nothing but an arbitrary choice made for git-extras.

Oh, and most of the scripts in here don't even need bash. A POSIX compatible sh is still the most common shell.

I will come up with something.