CDN is caching errors - Githubissues

tj / gobinaries

Golang binaries compiled on-demand for your system

https://gobinaries.com/

MIT License

814 stars 31 forks source link

CDN is caching errors #38

Open karimsa opened 3 years ago

karimsa commented 3 years ago

Prerequisites

[X] I searched to see if the issue already exists.

Description

When an install fails, the CDN caches the error. Not sure if this is desirable behaviour, but it might not make sense for errors that are temporary (i.e. timeouts, network issues, etc.).

Steps to Reproduce

Try to install a package that fails.
Retry, the request will hit the cache (cf-cache-status: HIT, expecting a miss here).

Screen Shot 2021-04-02 at 12 01 02 AM

Slack

Join us on Slack https://chat.apex.sh/

tj commented 3 years ago

hmm yeah that doesn't sound right, as far as I remember I just have some default settings in CF, so that seems like odd behaviour. I'll try to check it out