search

tj / node-migrate

Abstract migration framework for node
MIT License
1.54k stars 224 forks source link

allow using esm modules in migrations #185

Closed Ti-webdev closed 1 year ago

Ti-webdev commented 3 years ago

The first commit add support migrations with .ejs extension But without upgrade dependencies (second commit) dynamical import for that does not supported with old version of standard (standard Parsing error: Unexpected token import). So time to update everything...

mkovel commented 3 years ago

@Ti-webdev any updates here?

mkovel commented 3 years ago

@wesleytodd Can you merge it?

mkovel commented 3 years ago

@Ti-webdev Could you also add info to Read.me according to your imps?

wesleytodd commented 3 years ago

Sorry, I did not see this PR until now, but also no we cannot merge it. This makes sweeping changes to the code base. I will happily review and take small updates, especially if there is a small PR which only does what the title suggests this would do. @Ti-webdev, if you are interested in slimming this one down to a tight scope to enable ESM usage that would be great.

@mkovel, many folks follow this repo, so please be courteous folks time and energy and consolidate your posts together to reduce noise in the future. Thanks!

wesleytodd commented 1 year ago

Addressed in #199