unescape fallback for malformed uri components

tj / node-querystring

querystring parser for node and the browser - supporting nesting (used by Express, Connect, etc)

MIT License

455 stars 66 forks source link

unescape fallback for malformed uri components #20

Open denisu opened 13 years ago

denisu commented 13 years ago

instead of just ignoring wrong encoded uri components, we should at least unescape them with the default javascript unescape function, which doesn't break on malformed encodings.

this fixes issues in a messed up iso-8859-1 environment.

tj commented 13 years ago

mind adding a test before I merge?

denisu commented 13 years ago

sure :).

i also added a case to test if iso-8859-1 data is unescaped correctly. i am not sure if this is an issue we should care about though. if it doesn't belong there, leave it out.

jonathanong commented 10 years ago

@denisu wanna rebase by any chance?