search

tj / node-querystring

querystring parser for node and the browser - supporting nesting (used by Express, Connect, etc)
MIT License
455 stars 66 forks source link

clean up messy stringify tests #25

Closed tj closed 10 years ago

sebs commented 10 years ago

starting to work on this atm

sebs commented 10 years ago

still working on it see here

https://github.com/sebs/node-querystring/

sebs commented 10 years ago

I will need some help naming those nested cases. They are not comprehensible to me by just reading the input and output. We could split that up in multiple types of nesting.

buschtoens commented 10 years ago

Can't really help you as I'm on my iPhone right now.

Sometimes we can't really find meaningful names, because the tests grow to abstract. Try using the literal query string. We just have to identify it anyhow.

I'll take a look at your cases anyway and try to come up with names. ;)

sebs commented 10 years ago

Cool, since I rewrote all the tests from stringify to parse (#facepalm) ... I have to work a bit more. Its good for the structure though

sebs commented 10 years ago

https://github.com/visionmedia/node-querystring/pull/81

Named, resorted and done as far as I am concerned. Please merge or comment ;)