Avoid infinite loop when a native prototype has an enumerable property

tj / node-querystring

querystring parser for node and the browser - supporting nesting (used by Express, Connect, etc)

MIT License

455 stars 66 forks source link

Avoid infinite loop when a native prototype has an enumerable property #63

Closed eivindfjeldstad closed 11 years ago

eivindfjeldstad commented 11 years ago

fixes visionmedia/express#1606

tj commented 11 years ago

looks like it's broken for 0.11.0 we'll have to check that out, some v8 changes or something. I kinda feel a little meh about all these changes in general, unfortunately it's pretty easy to break just about any node process from the outside in a number of ways but I guess that's not excuse not to try and patch them up haha, node is incredibly brittle though

eivindfjeldstad commented 11 years ago

yeah, this one is silly. people shouldn't be messing with native prototypes, but i guess it's worth preserving compatibility