search

tj / node-querystring

querystring parser for node and the browser - supporting nesting (used by Express, Connect, etc)
MIT License
455 stars 66 forks source link

Use hasOwnProperty when iterating over Array #66

Closed dougwilson closed 11 years ago

dougwilson commented 11 years ago

This fixes the issue from issue #65. In the tests, I added a dummy property to Array.prototype so the issue shows up in the tests. I then added hasOwnProperty checks to two for ... in loops that loop over arrays, which fixes the issue.

dougwilson commented 11 years ago

@visionmedia the tests failed in node 0.11, but I see you noted in #63 the tests failed in node 0.11, so they are not due to this commit. I also checked out the Travis CI logs and the errors here are the same as seen in #63.

dougwilson commented 11 years ago

Thank you, @visionmedia :palm_tree:

tj commented 11 years ago

thanks for the fix!