Fix behavior of instanceOf if valueOf defined

tj / should.js

BDD style assertions for node.js -- test framework agnostic

MIT License

2.75k stars 194 forks source link

Fix behavior of instanceOf if valueOf defined #114

Closed tvjg closed 11 years ago

tvjg commented 11 years ago

Fixes behavior of instanceOf reported in #107. If custom valueOf returned a primitive, Object.should type-coerced the object under test.
Adds a test to verify correct behavior.

btd commented 11 years ago

Solution looks ugly. valueOf used there because of wrappers like Number and so on. It is better just process this 3 case when valueOf makes sense: Number, Boolean, String. Only Date by default have not default valueOf from Object and we do not need it.

btd commented 11 years ago

Fixed