search

tj / should.js

BDD style assertions for node.js -- test framework agnostic
MIT License
2.75k stars 195 forks source link

Blockify #155

Closed alsotang closed 10 years ago

alsotang commented 10 years ago

Extend features of .property .properties and .keys

btd commented 10 years ago

I very like your idea. Looking superficially on code i found some problems:

  1. Code is very ugly, sorry but in such way i will not accept it (i will write more about it at weekend)
  2. It is not mergeble now, pls, pull last master.
  3. You did not cover .not cases (in tests also - at least for .property).
  4. Now .properties intersects with .include.
alsotang commented 10 years ago

OK. I would like to improve my code if this blockify idea seems reasonable for should.js.

problem 2 and 3 I think it only problem of time, and I will fix them.

refer to 4, em...I personally dont think it would make some kind of confusion. Since .type is also intersects with .String and .Number. Some old API always intersects with new features. It's a common thing. But for blockify and .properties, it behave unified.

problem 1 I would listen to your subsequent suggestion. :)

(sorry for my bad english..)

alsotang commented 10 years ago

Add .not tests

alsotang commented 10 years ago

@btd ,I've already fix my code refer to your suggestions. Please give some response when you have time. : )

btd commented 10 years ago

@alsotang Sorry. I already looked on this, but very busy these days.

btd commented 10 years ago

Hi, there. Sorry, i did not used your code at all, but added your idea to .match and .matchEach. And i mention you in commit message and in history. If you can pls take a look on test to see what it can.

alsotang commented 10 years ago

OK. I think the newly should.js 3.0.0 is a wonderful release. I would continue watching this project and contribute. Thanks for your effort!