Closed rafmagana closed 12 years ago
any comment?
what do you think now?
looks a lot better, ill comment inline
what do you think now?
merged/tweaked as a single commit
in general though shorter variable names (that still make sense) == better
cool, thanks!
Some days ago I was using should.js to test an API, I needed to test against a JSON object which was a response from the API, there was some properties/values in the response I didn't care about, look at this case:
Reponse
Wanted to test if the properties/values of this object were part of the response:
should.include and includeEql to the rescue, right? well, no
so I made this patch to support just that, hope you find it interesting.
maybe I should have added this feature to the includeEql() method, I just think includeEql() is confusing, I'd like to have the include() and includeEql() functionality in the same method but I'd like to know what you think.
Thanks.