Code formatting and pushd compatibility updates

tjanczuk / wns

Send push notifications to Windows 8 devices using WNS

Apache License 2.0

52 stars 30 forks source link

Code formatting and pushd compatibility updates #17

Closed ojarva closed 3 years ago

ojarva commented 9 years ago

This pull request changes three different things:

Formatting: added {} for longer if statements, few small spelling fixes and converted all tabs to spaces.
Renamed x-wns-notificationstatus to x-wns-status. x-wns-notificationstatus header still exists, but it is deprecated.
Added "shouldDeleteChannel" attribute when appropriate. If error code from notify.microsoft.com is 403, 404 or 410, channel should not be used anymore. This improves API compatibility with for example MPNS library.

pke commented 8 years ago

good additions. I wonder if they will ever be merged?

ojarva commented 8 years ago

I doubt that will ever happen, based on project activity during past few years

pke commented 8 years ago

Yeah it seems so. There seem to be other nodejs solutions that handle WNS as well as the Android and Apple use cases anyway. So I guess this project is pretty dead.

daohoangson commented 7 years ago

@pke what is the solution that you mentioned?

pke commented 7 years ago

This one https://www.npmjs.com/package/cordova-plugin-push-notification or cordova-plugin-push

daohoangson commented 7 years ago

@pke from my understanding that package does not implement push mechanism at all. It allows receiving notification on the device only.

alex-friedl commented 6 years ago

Hello @ojarva, I am a new maintainer for this repository and would like to merge your proposed changes. Could you resolve the merge conflicts and answer my one question from the review ? :)

ojarva commented 6 years ago

I can do that next week. However, I'm no longer using this library, so if any major changes in addition to rebase are needed, I recommend someone else adopts this PR.

alex-friedl commented 5 years ago

@ojarva how about that rebase? :) no other changes would be required in order for me to merge it.

ojarva commented 3 years ago

That rebase would have required quite a bit of work thanks to three year's wait.