search

tjanczuk / wns

Send push notifications to Windows 8 devices using WNS
Apache License 2.0
52 stars 30 forks source link

Fix simultaneous send requests while obtaining token #3

Closed rudyzeinoun closed 12 years ago

rudyzeinoun commented 12 years ago

If you are sending a push notification for the first time, a token will be retrieved. During that time, if you attempt to send another message, it gets queued, but produces a fatal error. This is because a new request for a new token is made.

Another fix for UTF-8 messages.

tjanczuk commented 12 years ago

Thank you for the issue report and fix! Since this project is owned by Microsoft, before I can merge the pull request I need to ask you to sign the CLA. Please download [http://windowsazure.github.com/docs/Contribution License Agreement.pdf](http://windowsazure.github.com/docs/Contribution License Agreement.pdf). Fill in, sign, scan/photo and email it to cla@microsoft.com. You can learn more about the contribution guidelines at http://windowsazure.github.com/guidelines.html.

rudyzeinoun commented 12 years ago

Hello Tomasz,

I am sending the agreement now to the mentioned e-mail address.

Thank you, Rudy

On Mon, Jul 30, 2012 at 8:50 PM, Tomasz Janczuk < reply@reply.github.com

wrote:

Thank you for the issue report and fix! Since this project is owned by Microsoft, before I can merge the pull request I need to ask you to sign the CLA. Please download [http://windowsazure.github.com/docs/ContributionLicense Agreement.pdf](http://windowsazure.github.com/docs/Contribution License Agreement.pdf). Fill in, sign, scan/photo and email it to cla@microsoft.com. You can learn more about the contribution guidelines at http://windowsazure.github.com/guidelines.html.

Reply to this email directly or view it on GitHub: https://github.com/tjanczuk/wns/pull/3#issuecomment-7375995

tjanczuk commented 12 years ago

Thank you for your fix. May I ask what you are building?

rudyzeinoun commented 12 years ago

I'm building a push notification manager with an API for a Windows 8 application. We are a Microsoft partner and have developed an app for a local newspaper.

Are you an MS employee?

Sent from my Windows Phone From: Tomasz Janczuk Sent: 31/07/2012 7:56 PM To: rudyzeinoun Subject: Re: [wns] Fix simultaneous send requests while obtaining token (#3) Thank you for your fix. May I ask what you are building?

Reply to this email directly or view it on GitHub: https://github.com/tjanczuk/wns/pull/3#issuecomment-7404579

tjanczuk commented 12 years ago

Thanks. Yes, I am working for Microsoft.

From: rudyzeinoun [reply@reply.github.com] Sent: Tuesday, July 31, 2012 10:33 AM To: Tomasz Janczuk Subject: Re: [wns] Fix simultaneous send requests while obtaining token (#3)

I'm building a push notification manager with an API for a Windows 8 application. We are a Microsoft partner and have developed an app for a local newspaper.

Are you an MS employee?

Sent from my Windows Phone From: Tomasz Janczuk Sent: 31/07/2012 7:56 PM To: rudyzeinoun Subject: Re: [wns] Fix simultaneous send requests while obtaining token (#3) Thank you for your fix. May I ask what you are building?

Reply to this email directly or view it on GitHub: https://github.com/tjanczuk/wns/pull/3#issuecomment-7404579

Reply to this email directly or view it on GitHub: https://github.com/tjanczuk/wns/pull/3#issuecomment-7405621