"ьЬь" inserted between each character when transliterating back to Russian

tjbladez / translit

Transliteration between cyrillic <-> latin | Транслитерация между кирилицой и латиницой

67 stars 37 forks source link

"ьЬь" inserted between each character when transliterating back to Russian #13

Open Stratus3D opened 7 years ago

Stratus3D commented 7 years ago

This commit (997899c68112edce325c8e1ac2768f8e2835ecfc) introduces a bug that causes "ьЬь" to be inserted between each character when transliterating back to Russian. The key with a value of "" is invalid. The key should be "'".

Stratus3D commented 7 years ago

This is fixed in https://github.com/euroteamoutreach/translit/pull/1

tjbladez commented 6 years ago

I will be happy to merge this in if you want to open up the pull request. We can version and republish the gem after that.

Stratus3D commented 6 years ago

Do you want my PR to include the rspec tests I wrote?

tjbladez commented 6 years ago

Absolutely, specs value is tremendous and overall I think specs are necessary to guide developer usage. I will convert existing riot specs to rspecs as well as part of that release.