tjch-o / pe

0 stars 0 forks source link

No support for special characters in phone numbers #3

Open tjch-o opened 1 year ago

tjch-o commented 1 year ago

Phone numbers should allow special characters such as (, ) and - as other countries use special characters in their phone numbers.

image.png

nus-se-bot commented 1 year ago

Team's Response

As this application is made car insurances only in Singapore, clients that own a car in Singapore are required to have a valid Singapore citizenship and contact number before they can get a car insurance. Car insurance is mandatory for every car owner in Singapore. Hence, we took that into account when doing the constraints and decided that only valid Singapore handphone numbers (which is exactly 8 digits long) will be accepted for this parameter.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The UG or DG did not state at all that this application was made only for car insurances in Singapore, so it is not wrong for the user to assume that it can work for other countries as well. Therefore, I believe that this is still a valid feature flaw.

Proof where UG has no mention of Singapore:

image.png

Proof where DG has no mention of Singapore:

image.png