search

tjch-o / pe

0 stars 0 forks source link

More specific and accurate error messages regarding dates #8

Open tjch-o opened 1 year ago

tjch-o commented 1 year ago

When I tried add n/Seth Downson i/578A p/41413567 e/bobanderson@gmail.com a/Blk 233 Kent Ridge, #05-12 t/teacher l/SGP1208J c/DEF Insurance pn/263J pi/20-09-2023 pe/32-05-2027 it does raise an error which is good but the date is in the right format dd-mm-yyyy just that it is not valid as a month cannot have 32 days. It can be more accurate.

image.png

nus-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error does not inform me of incorrect dates when editing

image.png

The error does not tell me that it is not a leap year or give me an indication that the date I am entering does not exist which causes confusion for the user

[original: nus-cs2103-AY2324S1/pe-interim#2078] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We agree that it will be beneficial to tell the user about the invalid date formats, such as invalid dates in a non-leap year. However, as it requires very extensive checks with many if-else blocks, we think that it is not worth the time and resources in this iteration .

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** This should be of `severity.Low` instead of `severity.VeryLow` because it does cause some inconvenience for the user since the user does not know the fault in the date they set in.