Divorce cslbot from Linux-specific commands

[sapphire-arches]

Commands that currently rely on such trickery [ ] bc [ ] ddate [ ] eix [ ] errno [ ] fortune [ ] gcc [ ] ping [ ] pull [ ] version [ ] wtf

Some of these obviously can't be written platform-agnosticly (for things like eix, errno and gcc it makes no sense) but I think a few of these should definitely be doable.

At the very least we can provide nice messages when things fail

[an-empty-string]

pull - not linux-specific, this could theoretically use msysgit (I think) version - same case wtf - we're going to need to create a database of acronyms ping - probably platform-specific command (if posix then ping -c1, else ping -whateverthethingisinwindows) gcc, eix, errno - like you said bc - we can write a simple expression parser for this one

[sckasturi]

Or do what weechat does and require it be run in cygwin :P That way !bc and a couple others will still work.

-----

• Tech http://techfilmer.com/Filmer http://youtube.com/techfilmer *

On Wed, Jan 15, 2014 at 10:33 PM, fwilson42 notifications@github.comwrote:

pull - not linux-specific, this could theoretically use msysgit (I think) version - same case wtf - we're going to need to create a database of acronyms ping - probably platform-specific command (if posix then ping -c1, else ping -whateverthethingisinwindows) gcc, eix, errno - like you said bc - we can write a simple expression parser for this one

— Reply to this email directly or view it on GitHubhttps://github.com/tjcsl/cslbot/issues/678#issuecomment-32439700 .

[sapphire-arches]

@TechFilmer That is a terrible terrible idea - most of the bot is OK outside of POSIX environments, with the exception of these few commands.

[pefoley2]

There is no way in hell that cygwin should be a requirement

[sckasturi]

Alias !math to !wolf perhaps? That'll fix !bc's issue.

[pefoley2]

that's really tangential to this issue.

[an-empty-string]

How about using eval without any functions defined?

[sdamashek]

We would have to be REALLY careful about that, but if it's implemented safely and securely that would work. Fast too compared to wolfram alpha.

[pefoley2]

I took a look at doing that safely (it didn't work), but i'm not sure that this is enough of an issue to justify running eval on user input.

[sckasturi]

Maybe if it doesn't return an int we don't send the output?

-----

• Tech http://techfilmer.com/Filmer http://youtube.com/techfilmer *

On Thu, Mar 20, 2014 at 10:10 PM, Peter Foley notifications@github.comwrote:

I took a look at doing that safely (it didn't work), but i'm not sure that this is enough of an issue to justify running eval on user input.

— Reply to this email directly or view it on GitHubhttps://github.com/tjcsl/cslbot/issues/678#issuecomment-38242542 .

[pefoley2]

do you have the slightest clue what eval does?

[an-empty-string]

That's even worse... Supybot has some code to do this sort of thing -- let's look at that.